Quick note, as one of the most popular posts I’ve made is about how to raise your weapon skill, Google searchers should not that in Cataclysm the concept of a weapon skill will be removed from the game. Having spent a long time swinging at low mobs, I really like that I don’t have to micromanage a set of skills. It is a good change.
So I’d say if you’ve not got that feat of Strength achievement, then get it now.
And if you have no interest in the achievement, then don’t burn the time raising the skill – as you won’t have to. Go read a book, grind for that rare drop, or farm gold and send it to me.